Safer test for class vs string

scrapinghub · Sep 14, 2023 · a75e6fb · a75e6fb
1 parent 6c1a7d8
commit a75e6fb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/spidermon/contrib/scrapy/pipelines.py b/spidermon/contrib/scrapy/pipelines.py
@@ -56,7 +56,7 @@ def set_validators(loader, schema):
             if type(schema) in (list, tuple):
                 schema = {Item: schema}
             for obj, paths in schema.items():
-                key = obj if type(obj) in (str) else obj.__name__
+                key = obj.__name__ if hasattr(obj, "__name__") else str(obj)
                 paths = paths if type(paths) in (list, tuple) else [paths]
                 objects = [loader(v) for v in paths]
                 validators[key].extend(objects)

diff --git a/tests/contrib/scrapy/test_pipelines.py b/tests/contrib/scrapy/test_pipelines.py
@@ -206,7 +206,9 @@ class PipelineJSONSchemaValidator(PipelineTest):
         DataTest(
             name="validators specified by str rather than class",
             item=TreeItem(),
-            settings={SETTING_SCHEMAS: {"TestItem": test_schema, "TreeItem": tree_schema}},
+            settings={
+                SETTING_SCHEMAS: {"TestItem": test_schema, "TreeItem": tree_schema}
+            },
             cases=[
                 f"{{stats}}['{STATS_MISSINGS}'] is 1",
                 assert_type_in_stats(TestItem),