allow pass extra settings for portiacrawl close #63 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| parser.add_option("--output", "-o", help='dump scraped items into FILE (use - for stdout)', metavar='FILE') | ||
| parser.add_option("--output-format", "-t", metavar='FORMAT', help='format to use for dumping items with -o (default: jsonlines)') | ||
| parser.add_option("--verbose", "-v", action="store_true", default=True, help="more verbose") |
There was a problem hiding this comment.
I am not sure if verbose should default to true. Also I would make the help message more accurate, something on the lines of "Prints the command used to run the crawler".
duendex
added a commit
that referenced
this pull request
Jul 1, 2014
allow pass extra settings for portiacrawl close #63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now besides add setting to
slyd/slyd/settings.py, portiacrawl also allow user adding extra settings from command line. e.g.slybot/bin/portiacrawl -v slyd/data/projects/new_project/ www.yelp.co.uk -a start_urls=http://www.yelp.co.uk/biz/barrafina-london -s DEPTH_LIMIT=1