Kafka 1.0.x support, take 2 #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.19% (diff: 41.14%)@@ master #223 diff @@
==========================================
Files 68 68
Lines 4500 4690 +190
Methods 0 0
Messages 0 0
Branches 589 636 +47
==========================================
+ Hits 3259 3292 +33
- Misses 1095 1253 +158
+ Partials 146 145 -1
|
sibiryakov
force-pushed
the
kafka-10x-2
branch
from
fd9366c to
ea41a00
Compare
Member
Author
|
@Preetwinder pls have a look! |
Contributor
|
LGTM, nothing stuck out to me. |
Member
Author
|
Now it works as it should be 👍 |
sibiryakov
force-pushed
the
kafka-10x-2
branch
from
f9caa4f to
b24d1bc
Compare
sibiryakov
force-pushed
the
kafka-10x-2
branch
from
b24d1bc to
e4fc178
Compare
sibiryakov
force-pushed
the
kafka-10x-2
branch
from
375eb4e to
f767203
Compare
Member
Author
|
Oh, finally!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.