Skip to content

Skip empty JSON-LD scripts by trimming and skipping empty input #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

burovytskyi
Copy link
Contributor

@burovytskyi burovytskyi commented Mar 24, 2025

Skipping empty JSON-LD scripts prevents parsing issues with blank data.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.62%. Comparing base (2fd175e) to head (f02cf23).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   89.58%   89.62%   +0.03%     
==========================================
  Files          13       13              
  Lines         634      636       +2     
  Branches      137      138       +1     
==========================================
+ Hits          568      570       +2     
  Misses         54       54              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gallaecio
Copy link
Member

Please, run pre-commit run --all-files, and consider adding a test for this change.

@Gallaecio Gallaecio merged commit a31daaa into scrapinghub:master Mar 24, 2025
8 checks passed
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants