Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set a max length of 119 characters and the
flake8
on the pipelines was using that value from thepytest.ini
(flake8-max-line-length
). However, there were some references to 100 characters. I updated the docs (CONTRIBUTING.rst
) and thesetup.cfg
.On the other hand, when using the
flake8
tool directly (instead of using it along withtox
), theflake8
file wasn't working. I checked the flake8 documentation, and that file is not accepted, in any case, it should start with a period (.flake8
):So I removed it. Then I also realized that it would be a good idea to have a "single point of truth", and as
pytest-flake8
will take the values from thesetup.cfg
, I removed theflake8-max-line-length
from thepytest.ini
.Finally, and following with the last idea, I moved the
flake8
excusion rules to thesetup.cfg
.