Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean testing dependencies #784

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

noviluni
Copy link
Collaborator

I removed some unnecessary test dependencies and updated parts of the code.

@noviluni noviluni requested a review from Gallaecio September 11, 2020 11:26
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #784 into master will decrease coverage by 2.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   98.34%   95.57%   -2.78%     
==========================================
  Files         231      304      +73     
  Lines        2484     2600     +116     
==========================================
+ Hits         2443     2485      +42     
- Misses         41      115      +74     
Impacted Files Coverage Δ
dateparser/search/detection.py 94.33% <0.00%> (-1.50%) ⬇️
dateparser/conf.py 100.00% <0.00%> (ø)
dateparser/utils/__init__.py 97.41% <0.00%> (ø)
dateparser/calendars/jalali_parser.py 100.00% <0.00%> (ø)
dateparser/data/numeral_translation_data/cy.py 0.00% <0.00%> (ø)
dateparser/data/numeral_translation_data/my.py 0.00% <0.00%> (ø)
dateparser/data/numeral_translation_data/ta.py 0.00% <0.00%> (ø)
dateparser/data/numeral_translation_data/fr-BE.py 0.00% <0.00%> (ø)
...ateparser/data/numeral_translation_data/zh-Hant.py 0.00% <0.00%> (ø)
dateparser/data/numeral_translation_data/nb.py 0.00% <0.00%> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f01811...ef80d77. Read the comment docs.

@noviluni noviluni force-pushed the clean_testing_dependencies branch from 9853953 to ef80d77 Compare September 14, 2020 21:13
@noviluni noviluni merged commit 31d4543 into scrapinghub:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants