-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pypy and python2 from tox and travis. #744
Remove pypy and python2 from tox and travis. #744
Conversation
This should help one step in closing scrapinghub#727
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
- Coverage 95.61% 95.23% -0.38%
==========================================
Files 304 304
Lines 2646 2646
==========================================
- Hits 2530 2520 -10
- Misses 116 126 +10
Continue to review full report at Codecov.
|
The coverage data reveals a few parts of the code that are specific to Python 2 and can be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The coverage data reveals a few parts of the code that are specific to Python 2 and can be removed.
@Gallaecio , let's do this in a next PR!
re pypy removal - maybe it makes sense to add pypy3 then, maybe as part of another PR? |
Hi @lopuhin, I tried it and the tests were totally broken. The |
Anyway, this is the first step on a list of steps to get rid of Python 2. We will:
We don't need to perform these steps in this strict order, but I think it's a good way to go, let me know if there is any wrong on this approach or if you have any other idea. |
Thanks @noviluni yes makes sense to tackle pypy3 separately. Re the steps you outlined - they make sense, I don't have experience with 2to3, only with manual porting, but usually py2-specific code stands out. |
Hi @noviluni @Gallaecio we should merge this only after coverage is fixed or can do now? |
I think we can merge already and tackle the coverage part separately, as @noviluni suggested. |
Good job! Now we can say that we don't support Python 3 officially 🤣 |
This should help one step in closing #727