Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with the formats included in the
base-formats
parser (_try_hardcoded_formats
method) and it seems that all of them are now fully supported by theabsolute-time
parser, so I think it doesn't have any sense to keep this parser, as it adds unnecessary complexity.In fact, all the date formats with commas were not applied correctly: #720 and that means that only 3 of the past date formats were applied.
Examples:
'%B %d, %Y, %I:%M:%S %p'
'%b %d, %Y at %I:%M %p'
'%d %B %Y %H:%M:%S'
'%A, %B %d, %Y'
'%Y-%m-%dT%H:%M:%S.%fZ'