Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve fr support #672

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

noviluni
Copy link
Collaborator

@noviluni noviluni commented May 12, 2020

Includes additions from the next PRs:

Most of them modify the json file instead of the yaml file, so we could close them after releasing this.

Also fixes: #354

@noviluni noviluni requested a review from rennerocha May 12, 2020 15:29
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #672   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         302      302           
  Lines        2558     2558           
=======================================
  Hits         2436     2436           
  Misses        122      122           
Impacted Files Coverage Δ
dateparser/data/date_translation_data/en.py 100.00% <ø> (ø)
dateparser/data/date_translation_data/fr.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b298b33...3e94eab. Read the comment docs.

@noviluni noviluni removed the request for review from rennerocha May 12, 2020 17:07
@noviluni noviluni merged commit 4be1e9d into scrapinghub:master May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with relative dates in french like "il y a 3 années"
3 participants