Add pytest flake8 #665
Merged
Add pytest flake8 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noviluni
commented
May 2, 2020
| @@ -314,7 +314,7 @@ def _get_datetime_obj(self, **params): | |||
| try: | |||
| return datetime(**params) | |||
| except ValueError as e: | |||
| error_text = getattr(e, 'message', None) or e.__str__() | |||
| error_text = e.__str__() | |||
There was a problem hiding this comment.
e.message was deprecated since Python 2.6 and we don't support Python versions below 2.7
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 302 302
Lines 2558 2558
=======================================
Hits 2436 2436
Misses 122 122
Continue to review full report at Codecov.
|
noviluni
force-pushed
the
add_pytest_flake8
branch
from
da1353c
to
87bc526
Compare
|
Are those Git submodules added on purpose? I’m not sure if I am reading the diff correctly. |
noviluni
force-pushed
the
add_pytest_flake8
branch
3 times, most recently
from
3644424
to
8b97e9d
Compare
|
Hi @Gallaecio I'm not sure why those git submodules were added 😅 I pushed a clean version of the branch, could you review it again? Sorry for the inconvenience |
noviluni
commented
May 12, 2020
noviluni
commented
May 12, 2020
Gallaecio
approved these changes
May 12, 2020
noviluni
force-pushed
the
add_pytest_flake8
branch
from
f2d62d2
to
226c0d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pytest-flake8 pipeline.
Note when reviewing that this PR includes code from this PR to avoid conflicts: #664