-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest flake8 #665
Add pytest flake8 #665
Conversation
@@ -314,7 +314,7 @@ def _get_datetime_obj(self, **params): | |||
try: | |||
return datetime(**params) | |||
except ValueError as e: | |||
error_text = getattr(e, 'message', None) or e.__str__() | |||
error_text = e.__str__() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.message
was deprecated since Python 2.6 and we don't support Python versions below 2.7
Codecov Report
@@ Coverage Diff @@
## master #665 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 302 302
Lines 2558 2558
=======================================
Hits 2436 2436
Misses 122 122
Continue to review full report at Codecov.
|
da1353c
to
87bc526
Compare
Are those Git submodules added on purpose? I’m not sure if I am reading the diff correctly. |
3644424
to
8b97e9d
Compare
Hi @Gallaecio I'm not sure why those git submodules were added 😅 I pushed a clean version of the branch, could you review it again? Sorry for the inconvenience |
f2d62d2
to
226c0d0
Compare
Add pytest-flake8 pipeline.
Note when reviewing that this PR includes code from this PR to avoid conflicts: #664