Skip to content

Conversation

@harsh9200
Copy link

@harsh9200 harsh9200 commented Apr 28, 2020

Transferring Data from JSON Files to YAML Files.

Context: #638 (comment)

@harsh9200
Copy link
Author

Please Review @Gallaecio

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #659   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         302      302           
  Lines        2506     2506           
=======================================
  Hits         2386     2386           
  Misses        120      120           
Impacted Files Coverage Δ
dateparser/data/date_translation_data/en.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb79181...3d679d1. Read the comment docs.

@noviluni
Copy link
Collaborator

Is this PR finished? In that case, could you remove the "[WIP]" from the title? @harsh9200

@harsh9200
Copy link
Author

harsh9200 commented Apr 29, 2020

Is this PR finished?

No, I will add more data so that my other PR's can also be merged. I will inform you when I am done.

@noviluni

@harsh9200
Copy link
Author

This PR is ready now.

@noviluni

@harsh9200 harsh9200 changed the title [WIP] Extending YAML Files Extending YAML Files Apr 30, 2020
@harsh9200 harsh9200 closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants