-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing parse behaviour for 8 digit date #639
Changing parse behaviour for 8 digit date #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 95.21% 95.23% +0.02%
==========================================
Files 302 302
Lines 2506 2521 +15
==========================================
+ Hits 2386 2401 +15
Misses 120 120
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as long as it does not break any existing tests (it does not 👍). Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @arnavkapoor !! Thanks you!! 🚀
Fixes #618
An attempt at #618 , the objective is to improve the parsing of dates of the form XXXXXXXX (Any 8 digit number).
Updated parsing results after this fix
20202001 datetime.datetime(2020, 1, 20, 0, 0)
01201702 datetime.datetime(1702, 1, 20, 0, 0)
01202020 datetime.datetime(2020, 1, 20, 0, 0)
20202020 datetime.datetime(2002, 2, 2, 0, 2)
For the last case
20202020
it's going back to the default behavior.