Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date parsing return from README and docs usage page #619

Merged

Conversation

lucasdutraf
Copy link
Contributor

fixes #617

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #619 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #619   +/-   ##
======================================
  Coverage    95.2%   95.2%           
======================================
  Files         302     302           
  Lines        2502    2502           
======================================
  Hits         2382    2382           
  Misses        120     120
Impacted Files Coverage Δ
dateparser/freshness_date_parser.py 98.94% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5f2a1...8655ecb. Read the comment docs.

@buriy
Copy link

buriy commented Feb 19, 2020

Have you checked the code works properly and only docs needs to be addressed?

Copy link
Collaborator

@noviluni noviluni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lucasdutraf ! Thank you for the fix! 🎉

@buriy yes, it was a typo, it works in this way.

@Gallaecio Gallaecio merged commit 8998088 into scrapinghub:master Feb 19, 2020
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc MDY/DMY detection issue (incoherence? error?)
4 participants