Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis setup improvements #511

Merged
merged 1 commit into from
May 6, 2020
Merged

Travis setup improvements #511

merged 1 commit into from
May 6, 2020

Conversation

scop
Copy link
Contributor

@scop scop commented Mar 10, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #511 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         302      302           
  Lines        2558     2558           
=======================================
  Hits         2436     2436           
  Misses        122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183e7ec...6821842. Read the comment docs.

@Gallaecio
Copy link
Member

Looking at the conflicts, it looks like this should be simplified now to just adding 3.8 tests.

@noviluni
Copy link
Collaborator

noviluni commented May 6, 2020

Hi @scop, thank you for adding this PR! We added support for Python 3.8 and this generated conflicts, but your changes related to pip look good.

Could you solve the conflicts again? I will merge this PR just after you do it 🙌

Thanks in advance 🙂

@noviluni noviluni merged commit 975cc7e into scrapinghub:master May 6, 2020
@scop scop deleted the travis-more branch May 6, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants