Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some tests #317

Merged
merged 7 commits into from
Jun 12, 2017
Merged

added some tests #317

merged 7 commits into from
Jun 12, 2017

Conversation

sarthakmadaan
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #317 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   78.85%   79.12%   +0.26%     
==========================================
  Files          34       34              
  Lines        4001     4024      +23     
==========================================
+ Hits         3155     3184      +29     
+ Misses        846      840       -6
Impacted Files Coverage Δ
tests/test_date.py 97.56% <100%> (+0.21%) ⬆️
dateparser/date.py 95.89% <0%> (+3.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 157317d...cf71bc6. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #317 into master will increase coverage by 6.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   90.96%   97.61%   +6.64%     
==========================================
  Files          20       20              
  Lines        1683     1674       -9     
==========================================
+ Hits         1531     1634     +103     
+ Misses        152       40     -112
Impacted Files Coverage Δ
dateparser/parser.py 98.02% <ø> (+6.47%) ⬆️
dateparser/languages/__init__.py 100% <0%> (ø) ⬆️
dateparser/date.py 96.07% <0%> (+2.94%) ⬆️
dateparser/utils/strptime.py 100% <0%> (+7.69%) ⬆️
dateparser/utils/__init__.py 98.23% <0%> (+12.38%) ⬆️
dateparser/languages/validation.py 100% <0%> (+35.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0487a...ce21d59. Read the comment docs.

Copy link
Contributor

@waqasshabbir waqasshabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarthak5 it's a good starting point. There are still a couple misses which we can address like checking for this exception.

@waqasshabbir waqasshabbir merged commit 5308434 into scrapinghub:master Jun 12, 2017
@sarthakmadaan sarthakmadaan deleted the Add_Tests branch June 12, 2017 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants