New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve failing test for Python 3.6 #316

Merged

waqasshabbir merged 2 commits into scrapinghub:master from sarthakmadaan:resolve_failing_test

May 21, 2017

Contributor

sarthakmadaan commented May 14, 2017

tried to resolve a test that is failing for Python 3.6 because of a change in error message.

FAIL: test_dates_not_supported_by_date_time_2_24165_months_ago (tests.test_freshness_date_parser.TestFreshnessDateDataParser)
.
.
.
AssertionError: False is not true : Didn't found any of the expected messages (['year is out of range', "('year must be in 1..9999'"]) -- message was: ValueError('year 0 is out of range',)```

sarthakmadaan added 2 commits

May 14, 2017 22:42


          resolved failing test for python 3.6

bbc6d92


          added necessary changes

aeed618

waqasshabbir merged commit aeed618 into scrapinghub:master

sarthakmadaan deleted the resolve_failing_test branch

June 11, 2017 08:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet