Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Russian #1083

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Improve Russian #1083

merged 7 commits into from
Oct 12, 2022

Conversation

serhii73
Copy link
Collaborator

Close #657

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Base: 98.23% // Head: 98.23% // No change to project coverage 👍

Coverage data is based on head (05d7c43) compared to base (d1ab41f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files         232      232           
  Lines        2599     2599           
=======================================
  Hits         2553     2553           
  Misses         46       46
Impacted Files Coverage Δ
dateparser/data/date_translation_data/ru.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@serhii73 serhii73 requested review from wRAR and Gallaecio October 10, 2022 17:07
@serhii73 serhii73 added the language language related issue/PR label Oct 10, 2022
Gallaecio
Gallaecio approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (with no language knowledge). Please, address the recent conflict when you get a chance.

@Gallaecio Gallaecio merged commit 62a2a84 into master Oct 12, 2022
@Gallaecio
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

@Gallaecio Gallaecio Gallaecio approved these changes

Assignees
No one assigned
Labels
language language related issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhii73 @Gallaecio @wRAR @Fozar