PytzUsageWarning: The localize method is no longer necessary

[Ibo0815]

Full Usage warning:
PytzUsageWarning: The localize method is no longer necessary, as this time zone supports the fold attribute (PEP 495). For more details on migrating to a PEP 495-compliant implementation, see https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html date_obj = stz.localize(date_obj)

Line 35 in date_parser.py

Occurs when parsing this here: "2022-10-03 22:00:00"

Python Version:
3.9.1

[Gallaecio]

It should be fixed in 1.1.2, released today. Please, see if you can reproduce the issue with 1.1.2.

[Gallaecio]

#1062 (comment)

[zanieb]

👋 I can reproduce this on 1.1.4 with

import dateparser
from datetime import datetime

dateparser.parse(
    "in 3 hours",
    settings={
        "TO_TIMEZONE": "UTC",
        "RELATIVE_BASE": datetime.now(),
    },
)

I'm on Python 3.8

[owocado]

@madkinsz yeah interestingly I can also reproduce it on python 3.11 with dateparser 1.1.4

[PythonTryHard]

I did some digging. As of writing, dataparser's dependency tzlocal's latest stable (since dependency is not pinned) is 4.3 which utilises pytz-deprecation-shim.

dateparser/dateparser/freshness_date_parser.py

Line 4 in 7b469b1

from tzlocal import get_localzone

dateparser/dateparser/freshness_date_parser.py

Lines 40 to 41 in 7b469b1

	def get_local_tz(self):
	return get_localzone()

dateparser/dateparser/freshness_date_parser.py

Lines 74 to 76 in 7b469b1

	if not now.tzinfo:
	if hasattr(self.get_local_tz(), 'localize'):
	now = self.get_local_tz().localize(now)

As dateparser eagerly .localize(), this leads to the deprecation warning. This has been addressed upstream in this PR from tzlocal and is included after version 5.0b1. Install and it should be gone, though keep in mind the risk of beta versions.

And since tzlocal would have completed migration away from the deprecation shim by the time v5.0 hit stable, perhaps it's time to consider removing the if hasattr(obj, 'localize'): sections, since tzlocal now returns zoneinfo objects?