Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): multi days conferences are reported only for starting and ending days, not during the whole duration #924

Open
davinkevin opened this issue Mar 31, 2024 · 5 comments
Labels

Comments

@davinkevin
Copy link
Contributor

Hello 👋

I think it's a bug because I remember it was different before, but I might be wrong… and if it's the case it's an eventual good improvement to have.

Currently, a conference is reported with two elements in calendar view:

  • days are greyed out in the calendar during the conf
  • conference is reported in the sub-list when we click on the day

However, for a conference longer than 2 days, there is, imo, an issue:

  • only the first and last days are greyed out
  • conference is reported in the sublist ONLY for the first and last day

Here, an example for devoxx (be) in October this year:

On first day:
image

On second day, which is not the last day, list empty where I expect it to have it displayed
image

As a speaker, this bug prevents to see conflicts properly between conferences.

Thank you for your really good tool, see you all soon 👋

@scraly scraly added the bug label Mar 31, 2024
@HanzCEO
Copy link
Contributor

HanzCEO commented Jun 23, 2024

You are right, the older version retains the mark between days for a long event. Not just the starting and ending days. I will look into it when I have the time.

@HanzCEO
Copy link
Contributor

HanzCEO commented Jun 28, 2024

I found the way to fix this. However, the fix would need #1063 to be approved first so you can toggle the view. Here's a preview:

image

Before After
image image

Here's Devoxx at 10/10:
image

@scraly
Copy link
Owner

scraly commented Jun 28, 2024

#1063 have been approved and merged ;)

HanzCEO pushed a commit to HanzCEO/dca-new-view that referenced this issue Jun 28, 2024
@scraly
Copy link
Owner

scraly commented Aug 22, 2024

@HanzCEO have you got a fix? ;)

@HanzCEO
Copy link
Contributor

HanzCEO commented Aug 24, 2024

@scraly it's on #1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants