Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/locale dependent tests #92

Merged
merged 2 commits into from
Jan 30, 2015

Conversation

Kwestor
Copy link
Contributor

@Kwestor Kwestor commented Jan 30, 2015

Tests changed to use correct separator for floating numbers (one from current Locale).

Disclaimer required by the lawyers:

THE FOLLOWING DISCLAIMER APPLIES TO ALL SOFTWARE CODE AND OTHER MATERIALS CONTRIBUTED IN CONNECTION WITH THIS SOFTWARE:
THIS SOFTWARE IS LICENSED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE AND ANY WARRANTY OF NON-INFRINGEMENT, ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS.
ONLY THE SOFTWARE CODE AND OTHER MATERIALS CONTRIBUTED IN CONNECTION WITH THIS SOFTWARE, IF ANY, THAT ARE ATTACHED TO (OR OTHERWISE ACCOMPANY) THIS SUBMISSION (AND ORDINARY COURSE CONTRIBUTIONS OF FUTURES PATCHES THERETO) ARE TO BE CONSIDERED A CONTRIBUTION. NO OTHER SOFTWARE CODE OR MATERIALS ARE A CONTRIBUTION.

Some tests failed when your system had `,` as decimal separator instead of
`.`.
@sksamuel
Copy link
Member

Thanks for the PRs. What's the disclaimer thing about ?

@Kwestor
Copy link
Contributor Author

Kwestor commented Jan 30, 2015

Lawyers from my company force us to add this to every piece of code we contribute to open-source. I personally view it as C.Y.A. technique in case some damage will be done by this code.

@sksamuel
Copy link
Member

"THIS SOFTWARE MAY BE REDISTRIBUTED TO OTHERS ONLY BY EFFECTIVELY USING THIS OR ANOTHER EQUIVALENT DISCLAIMER IN ADDITION TO ANY OTHER REQUIRED LICENSE TERMS."

So am I required to keep your disclaimer in the codebase?

@Kwestor
Copy link
Contributor Author

Kwestor commented Jan 30, 2015

Hm.. instruction only said I have to include it in PR description. I can ask legal guys next Monday how it should be done.

There is a "OR ANOTHER EQUIVALENT DISCLAIMER" part and I think this disclaimer looks like a variation on 7. and 8. from Apache 2.0 licence, which you already have in your codebase:


7. Disclaimer of Warranty.
Unless required by applicable law or agreed to in writing, Licensor provides the
Work (and each Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied,
including, without limitation, any warranties or conditions of TITLE,
NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are
solely responsible for determining the appropriateness of using or
redistributing the Work and assume any risks associated with Your exercise of
permissions under this License.

8. Limitation of Liability.
In no event and under no legal theory, whether in tort (including negligence),
contract, or otherwise, unless required by applicable law (such as deliberate
and grossly negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special, incidental,
or consequential damages of any character arising as a result of this License or
out of the use or inability to use the Work (including but not limited to
damages for loss of goodwill, work stoppage, computer failure or malfunction, or
any and all other commercial damages or losses), even if such Contributor has
been advised of the possibility of such damages.

@sksamuel
Copy link
Member

Thats seems fair enough
On 30 Jan 2015 23:35, "Jerzy Müller" notifications@github.com wrote:

Hm.. instruction only said I have to include it in PR description. I can
ask legal guys next Monday how it should be done.

There is a "OR ANOTHER EQUIVALENT DISCLAIMER" part and I think this
disclaimer looks like a copy of 7. and 8. from Apache 2.0 licence, which
you already have:

  1. Disclaimer of Warranty.
    Unless required by applicable law or agreed to in writing, Licensor provides the
    Work (and each Contributor provides its Contributions) on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied,
    including, without limitation, any warranties or conditions of TITLE,
    NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE. You are
    solely responsible for determining the appropriateness of using or
    redistributing the Work and assume any risks associated with Your exercise of
    permissions under this License.
  2. Limitation of Liability.
    In no event and under no legal theory, whether in tort (including negligence),
    contract, or otherwise, unless required by applicable law (such as deliberate
    and grossly negligent acts) or agreed to in writing, shall any Contributor be
    liable to You for damages, including any direct, indirect, special, incidental,
    or consequential damages of any character arising as a result of this License or
    out of the use or inability to use the Work (including but not limited to
    damages for loss of goodwill, work stoppage, computer failure or malfunction, or
    any and all other commercial damages or losses), even if such Contributor has
    been advised of the possibility of such damages.


Reply to this email directly or view it on GitHub
#92 (comment)
.

sksamuel added a commit that referenced this pull request Jan 30, 2015
@sksamuel sksamuel merged commit c6ae6e2 into scoverage:master Jan 30, 2015
@sksamuel
Copy link
Member

Thanks for pr

@Kwestor Kwestor deleted the bugfix/locale-dependent-tests branch January 30, 2015 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants