-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cross compile to Scala.js #158
Conversation
@sksamuel @gslowikowski Hi guys, any chance to get it reviewed, merged and released? After it gets packaged and published to central we could continue with sbt-scoverage part, what do you think? |
Please consider merging this! |
What's the status of this? |
👍 |
Hi. I don't know ScalaJs. Why there are |
They contain the JVM-specific code, which has to be different on several platforms. |
But who (what class) uses this code in the runtime in JVM module? |
scalac-scoverage-plugin/scalac-scoverage-runtime/shared/src/main/scala/scoverage/Invoker.scala Line 4 in 200bc65
|
I see, thanks. |
Hello, everyone! Thank you. |
I don't think there's any specific plans to support scala.js. |
@sksamuel I don't understand what this is supposed to mean. This PR has been merged, so master contains support for Scala.js. It seems all that is needed is for new release to be published. The latest release, 1.1.1, is more than one year old. |
I was getting confused ignore me |
This is cleanup of #118 with additional work done in sbt-scoverage: scoverage/sbt-scoverage#166 and tests to verify it all works: scoverage/sbt-scoverage#167