Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cross compile to Scala.js #158

Merged
merged 5 commits into from
Jun 1, 2016
Merged

Add support for cross compile to Scala.js #158

merged 5 commits into from
Jun 1, 2016

Conversation

lustefaniak
Copy link
Contributor

This is cleanup of #118 with additional work done in sbt-scoverage: scoverage/sbt-scoverage#166 and tests to verify it all works: scoverage/sbt-scoverage#167

@lustefaniak
Copy link
Contributor Author

@sksamuel @gslowikowski Hi guys, any chance to get it reviewed, merged and released?

After it gets packaged and published to central we could continue with sbt-scoverage part, what do you think?

@julienrf
Copy link

Please consider merging this!

@OlivierBlanvillain
Copy link

What's the status of this?

@sksamuel sksamuel merged commit 200bc65 into scoverage:master Jun 1, 2016
@sksamuel
Copy link
Member

sksamuel commented Jun 1, 2016

👍

@gslowikowski
Copy link
Member

Hi. I don't know ScalaJs. Why there are Platform and Platform$ classes in scalac-scoverage-runtime jar file (jvm module) now? What are they for in JVM module?

@sjrd
Copy link

sjrd commented Jun 17, 2016

They contain the JVM-specific code, which has to be different on several platforms.

@gslowikowski
Copy link
Member

But who (what class) uses this code in the runtime in JVM module?

@sjrd
Copy link

sjrd commented Jun 17, 2016

@lustefaniak lustefaniak deleted the scala-js-support branch June 17, 2016 17:10
@gslowikowski
Copy link
Member

I see, thanks.

@vpavkin
Copy link

vpavkin commented Aug 23, 2016

Hello, everyone!
May I kindly ask about when this is planned to be released? (if there is such plan)

Thank you.

@sksamuel
Copy link
Member

I don't think there's any specific plans to support scala.js.

@sjrd
Copy link

sjrd commented Aug 24, 2016

@sksamuel I don't understand what this is supposed to mean. This PR has been merged, so master contains support for Scala.js. It seems all that is needed is for new release to be published. The latest release, 1.1.1, is more than one year old.

@sksamuel
Copy link
Member

I was getting confused ignore me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants