Print Doubles with two fraction digits using US locale

[lustefaniak]

In some locales (eg. polish), doubles are printed with , as decimal separator:

<scoverage statement-count="1250" statements-invoked="213" statement-rate="17,04" branch-rate="17,91" version="1.0" timestamp="1458599746821">

Which is not correct as it breaks all code relying on .toDouble in scala.

[gslowikowski]

I like this change, Scoverage reports should be locale and encoding agnostic.

I've just checked Scoverage Jenkins plugin sources. This plugin reads statement-rate and branch-rate from scoverage.xml and parses it using Double.parseDouble. parseDouble method does not support locales, so it shouldn't work now, if dot is not your decimal separator.

I didn't test it, just analyzed source code. You can talk to the author to confirm this (he is very kind person).

[lustefaniak]

I did that change after codacy/sbt-codacy-coverage was crashing on my machine.

Cobertura report had decimals printed as in sample snippet. Most of the scala code uses .toDouble or .toFloat and unfortunatelly it allows only . as decimal separator.

Double.parseDouble uses FloatingDecimal.parseDouble and I think that one is Locale agnostic so it should be fine.

[lustefaniak]

@sksamuel Hi Stephen, I tried changes locally and they work for me, is there anything more I should check to get it merged?

[gslowikowski]

Additionally you should revert this commit.

[lustefaniak]

I think it is already done, but I will do it explicitly as git revert

[gslowikowski]

LGTM, will test later with my scoverage-maven-plugin.

[jketterl]

this PR was just braught to my attention... i think this will fix bug #126 i reported a while back.

[gslowikowski]

Yes