Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoverageAggregator refuses to aggregate single file #156

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

parkan
Copy link
Contributor

@parkan parkan commented Mar 21, 2016

If only one scoverage.xml file is found, the aggregator refuses to produce output:

[info] Found 1 subproject report files [/Users/arkadiy/mine/L-SPACE/l_space/target/scala-2.11/scoverage-report/scoverage.xml]
[info] No subproject data to aggregate, skipping reports

This allows aggregation of a single file

Fixes #144

If only one scoverage.xml file is found, the aggregator refuses to produce output:

[info] Found 1 subproject report files [/Users/arkadiy/mine/L-SPACE/l_space/target/scala-2.11/scoverage-report/scoverage.xml]
[info] No subproject data to aggregate, skipping reports

This allows aggregation of a single file

Fixes scoverage#144
sksamuel added a commit that referenced this pull request Mar 21, 2016
CoverageAggregator refuses to aggregate single file
@sksamuel sksamuel merged commit b9a26fc into scoverage:master Mar 21, 2016
@sksamuel
Copy link
Member

👍

@joprice
Copy link

joprice commented Jun 14, 2016

I'm hitting this bug now. Did this end up in a release? I'm on sbt-scoverage 1.3.5, which is using scalac-scoverage-plugin 1.1.1.

@joprice
Copy link

joprice commented Jun 14, 2016

I had forgotten about this: #124 (comment). Seems like that's going to block this fix getting released.

@yunliaw
Copy link

yunliaw commented Aug 27, 2016

Got into the same problem. Has it been released yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants