Skip to content

Add Scala 3.3.4 around check to support excluded packages and filenames #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add Scala 3.3.4 around check to support excluded packages and filenames #561

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ddc3722
add Scala 3.3.4 to check for support around excluded packages and fil…
a-morales Oct 1, 2024
c6287ff
update scala version for excluded files and packages to lowest suppor…
a-morales Oct 1, 2024
448bbd3
update test file assertions
a-morales Oct 1, 2024
140c432
revert changes to scala 3.5.0 tests
a-morales Oct 1, 2024
fe32545
Duplicate scala3 coverage excluded tests for scala 3.3.4
a-morales Oct 1, 2024
ea175e7
include missing project/ directory for scala 3.3.4 tests
a-morales Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert changes to scala 3.5.0 tests
  • Loading branch information
@a-morales
a-morales committed Oct 1, 2024
commit 140c4326b6ace0f9deb0ecad6e77879befa0cdcc
2 changes: 1 addition & 1 deletion src/sbt-test/scoverage/scala3-coverage-excluded-files/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version := "0.1"

scalaVersion := "3.3.4"
scalaVersion := "3.5.0"

libraryDependencies += "org.scalameta" %% "munit" % "1.0.1" % Test

Expand Down
6 changes: 3 additions & 3 deletions src/sbt-test/scoverage/scala3-coverage-excluded-files/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
> test
> coverageReport
# There should be no directory for the excluded files
$ exists target/scala-3.3.4/scoverage-report/GoodCoverage.scala.html
-$ exists target/scala-3.3.4/scoverage-report/two
-$ exists target/scala-3.3.4/scoverage-report/three
$ exists target/scala-3.5.0/scoverage-report/GoodCoverage.scala.html
-$ exists target/scala-3.5.0/scoverage-report/two
-$ exists target/scala-3.5.0/scoverage-report/three
2 changes: 1 addition & 1 deletion src/sbt-test/scoverage/scala3-coverage-excluded-packages/build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version := "0.1"

scalaVersion := "3.3.4"
scalaVersion := "3.5.0"

libraryDependencies += "org.scalameta" %% "munit" % "1.0.1" % Test

Expand Down
6 changes: 3 additions & 3 deletions src/sbt-test/scoverage/scala3-coverage-excluded-packages/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
> test
> coverageReport
# There should be no directory for the excluded package
$ exists target/scala-3.3.4/scoverage-report/GoodCoverage.scala.html
-$ exists target/scala-3.3.4/scoverage-report/two
-$ exists target/scala-3.3.4/scoverage-report/three
$ exists target/scala-3.5.0/scoverage-report/GoodCoverage.scala.html
-$ exists target/scala-3.5.0/scoverage-report/two
-$ exists target/scala-3.5.0/scoverage-report/three