Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation to fix issue #144 #146

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fixed documentation to fix issue #144 #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rootbeerlib/src/main/java/com/scottyab/rootbeer/RootBeer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ public RootBeer(Context context) {
}

/**
* Run all the checks.
* To run the same check but without looking for the busybox binary to avoid a false positive for certain devices please
* see {@link #isRootedWithoutBusyBoxCheck() isRootedWithoutBusyBoxCheck}
* Run all the root detection checks.
*
* @return true, we think there's a good *indication* of root | false good *indication* of no root (could still be cloaked)
*/
Expand All @@ -52,12 +50,13 @@ public boolean isRooted() {
* @deprecated This method is deprecated as checking without the busybox binary is now the
* default. This is because many manufacturers leave this binary on production devices.
*/
@Deprecated
public boolean isRootedWithoutBusyBoxCheck() {
return isRooted();
}

/**
* Run all the checks apart including checking for the busybox binary.
* Run all the checks including checking for the busybox binary.
* Warning: Busybox binary is not always an indication of root, many manufacturers leave this
* binary on production devices
* @return true, we think there's a good *indication* of root | false good *indication* of no root (could still be cloaked)
Expand Down