Add node and edge properties

[russelljurney-upside]

I know this will make the graphs bigger, but could you add support for node and edge properties? This works great in Mermaid graphs.

[scottvr]

There is support for reading properties. Right now it can use them for coloring in ANSI mode, or for sorting left/right in a binary tree type layout. Also, labels are read and can be displayed instead of the node id.

So with that said, what do you want to do with the properties? If you tell me whether and how you'd like them used, maybe there's already a way, or certainly I can add a feature.

[scottvr]

Presently phart knows about 'side' (and 'position', 'dir', 'child') for accessing positioning hints (like left/right for binary tree sorting) for edges and 'color' and label for both edges and nodes. If you have a specific idea for how you'd like to use it that would help me out. As it is, because of that you could trivially pre-process your data, and copy whatever you want to appear as a the node's label into an attribute named 'label', and that will already work today.

I'm not sure how we'd handle displaying edge labels on an ASCII diagram with orthogonal layout, presumably intended to fit within a typical screen, since labels would eat an entire row above or below their edge (or overwrite the edge itself, wjhich could get dicey. Anyway, I'm interested to hear what it is you want to do with an attribute so I can see about prioritizing it.

Additionally, the latest code in main has support for various sorting strategies and you can specify any arbitrary node property to be used as the sort key. Just let me know what you'd like to be able to do with edge labels; support for reading them in PHART is already there, since your renderer=ACSIIRenderer(G) object is going to have the graph you passed to it at instantiation as renderer.graph.edges[u][v] so if you just tack an attribute on, you can do what you please with it.

I do something like:

edge_data = renderer.graph.get_edge_data(u, v)
foo_attr_val = edge_data.get("foo")

# or

renderer.graph.nodes[node_id]["some_attr"] = "foobar"

#and so on.

But if it's a new feature you want, just let me know.