Added esm bundle to output #9
Conversation
| "main": "dist/useEvent.js", | ||
| "main": "dist/index.js", | ||
| "types": "dist/useEvent.d.ts", | ||
| "module": "dist/useevent.mjs", |
There was a problem hiding this comment.
In general, this sounds like a great addition. Supporting ESM is a good idea.
However, looking at the compiled tsup output, I'm disappointed by the extra complexity. I'm a fan of simply using tsc, and its ESM output is much cleaner and easier to read or debug.
I would love if you could update this PR to simply use tsc, instead of introducing new dependencies.
There was a problem hiding this comment.
Since I was experimenting with this, I created #10
| @@ -2,7 +2,9 @@ | |||
| "name": "react-use-event-hook", | |||
| "version": "0.9.2", | |||
| "description": "Same as React's `useCallback`, but returns a stable reference.", | |||
| "main": "dist/useEvent.js", | |||
| "main": "dist/index.js", | |||
There was a problem hiding this comment.
Outputting to 2 sibling files (eg. useEvent.js, useEvent.mjs) does seem have some problems with some build tools.
There are some solutions listed here: https://www.sensedeep.com/blog/posts/2021/how-to-create-single-source-npm-module.html
TL;DR; I think it's best to output to 2 separate folders, eg. dist/cjs/useEvent.js and dist/mjs/useEvent.mjs
Current state
The library only supplies a
cjs&d.tsoutput.Why change
Even though bundlers, e.g. vite, have support for transforming
cjsintoesmit's nice when the transformation happens at library level.Result
This pr adds a
esmbundle to the output and updatespackage.jsonfields.