Import React namespace to improve React 17 compatibility with ESM #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React 17,
useInsertionEffect
does not exist.In #10, we are now exporting ESM, so
import { useInsertionEffect }
fails with React 17. Reported as #11.This PR fixes that by importing the
React
namespace instead.Considerations: does this defeat the purpose of building as ESM? Does this disable "tree shaking"? I don't imagine that React can be tree-shaken, so probably not.