Simplify parquet file creation #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Jun 6, 2024
duck/duckdb_test.go
Outdated
| } | ||
|
|
||
| func TestQueryFrameWithDisplayName(t *testing.T) { | ||
| t.Skip() |
There was a problem hiding this comment.
this test is currently failing -- @scottlepp can you take a look and make sure the behavior is what we want?
There was a problem hiding this comment.
this was added since the user sees the display names in grafana. when referencing fields in a sql expression, the user doesn't know the dataframe field name.
There was a problem hiding this comment.
I think i fixed it -- odd that it mutates the original field
ryantxu
commented
Jun 6, 2024
scottlepp
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the arrow.Table from the SDK to create parquet files