Fixing two problems with chase: An extra LED would be used. The LED aft... #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter the amount specified is turned off each time. Not needed.
scottjgibson
added a commit
that referenced
this pull request
Sep 16, 2012
Fixing two problems with chase: An extra LED would be used. The LED aft...
|
err; ignore my comment; I'm dumb |
irjudson
pushed a commit
to irjudson/moodcloud
that referenced
this pull request
Apr 13, 2014
Fixing two problems with chase: An extra LED would be used. The LED aft...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...er the amount specified is turned off each time. Not needed.
The problem could be seen when setting a few leds on:
sudo python pixelpi.py chase --chip WS2801 --num_leds 10 --refresh_rate 100
and then running chase with less pixels/leds
sudo python pixelpi.py chase --chip WS2801 --num_leds 6 --refresh_rate 100
What should happen, and does with the above fix, is that only the first 6 LEDs are used for the chase and the rest remain on.