Change request for Early Bound Types

[realekhor]

Hi Scott,

Our team in Capgemini really like the SPKL framework. Really great job!

With regards to Early Bound Types, it would seem the all entities will be created within a single file. We think having the entities generated in separate files will work better for our use cases. We are happy to contribute this back to the framework if this is OK with you.

Cheers.

[scottdurow]

Thanks for the encouraging words 👍
I agree it would be good to have the option to do this (although I don't do it myself)
A configuration option flag to turn on splitting could be added using a similar approach to Darly's implementation here - https://github.com/daryllabar/DLaB.Xrm.XrmToolBoxTools/blob/de389e0be4be4e2b05aaeceff484863ad61d136e/DLaB.CrmSvcUtilExtensions/BaseCustomCodeGenerationService.cs#L264

Since CrmSvcUtil doesn't give the option natively - the code file must then be parsed and split after it is generated.

A Pull Request would be very well received!

[realekhor]

Awesome! we will take this up and start looking at it now.

[realekhor]

Hi Scott, just finished the work to implement these changes, however I am having some issue creating a pull request. Probably I am doing something wrong :)

[realekhor]

Hi @scottdurow I eventually figured out how to address my issue. Pull request is now ready for your review:
#216
Thanks.

[realekhor]

Hi @scottdurow, without trying to put any pressure on you :) was wondering if you have had any time to review my pull request. Thanks.

[daryllabar]

@scottdurow are you shelling out to the crmsvcutil in order to Generate your entities? Why not just use my project? You'd just have to map from whatever your config settings are to the crmsvcutil.exe.config and use the dlls from the EarlyBoundGenerator crmsvcutil folder straight up.

[scottdurow]

@daryllabar If you could provide your wrapper assembly as a nuget package so it can be pulled in as part of the automated build that would make it easy to swap out.

@realekhor Would prefer for the code to be pulled into the Tasks Assembly - rather not introduce another assembly just for this one SourceCodeManipulator class

[daryllabar]

So I could easily add a nuget package that is just the CrmSvcUtil Extensions dll. You'd have to manage setting the the settings in the app.config and configuring the CrmSvcUtil to use the correct services in the command line. Would that work?

[realekhor]

@scottdurow , Roslyn provides a very simple approach for processing the generated file from crmsvcutil. However, I didn’t want Roslyn libraries polluting Spkl :). That is why I implemented it as a separate lib - agree one class in a lib is an overkill :)

[scottdurow]

@realekhor The Microsoft.CodeAnalysis.* packages will need to be downloaded either way - so let's keep it all in the spkl tasks assembly.

[daryllabar]

@scottdurow Would you want that nuget package: #215 (comment)

[realekhor]

@scottdurow updated pull request to reflect comments.

[scottdurow]

@daryllabar Absolutely - if you can point us at a nuget package that contains just the earlybound generator as an assembly that can be called - we can add as an option. Lots of people are asking for this.

[daryllabar]

@scottdurow Would you be able to set some config options in a config file and shell out to an exe? If that's the case, you can use the XrmToolBoxPlugin Early Bound Generator Nuget Package as is. I could also probably provide a C# dll that populates the config file correctly as well if that is helpful... Let me know.