-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplyfoc library issue #140
Comments
I think the issue is in Askuric's simplyfoc ... if a breaking changes is introduced (like a change in function's parameters) then he should have followed semantic version rules and not just bump a patch |
nanofoc simpleFOC version peg at 2.3.0 Fixes #140
Yeah, sorry about that! The changes were documented and announced, but we should pay attention to the version numbers as well. I created a PR: #142 |
Askuric's simplyfoc project has been updated to 2.3.1 and there is changes in function's parameteres, which will generate error in the code.
solution:
In the platfromio.ini file, lib_deps should be changed to:
askuric/Simple FOC@2.3.0
I think the typo "@^2.3.0" makes the version up to V2.3.1 unintentedly.
The text was updated successfully, but these errors were encountered: