Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplyfoc library issue #140

Closed
wangxinghe88 opened this issue Oct 16, 2023 · 2 comments · Fixed by #141
Closed

simplyfoc library issue #140

wangxinghe88 opened this issue Oct 16, 2023 · 2 comments · Fixed by #141

Comments

@wangxinghe88
Copy link

Askuric's simplyfoc project has been updated to 2.3.1 and there is changes in function's parameteres, which will generate error in the code.
solution:
In the platfromio.ini file, lib_deps should be changed to:
askuric/Simple FOC@2.3.0

I think the typo "@^2.3.0" makes the version up to V2.3.1 unintentedly.

@Edo78
Copy link

Edo78 commented Oct 16, 2023

I think the issue is in Askuric's simplyfoc ... if a breaking changes is introduced (like a change in function's parameters) then he should have followed semantic version rules and not just bump a patch

scottbez1 pushed a commit that referenced this issue Oct 18, 2023
nanofoc simpleFOC version peg at 2.3.0

Fixes #140
@runger1101001
Copy link

Yeah, sorry about that!

The changes were documented and announced, but we should pay attention to the version numbers as well.

I created a PR: #142
this fixes the compile errors, but as I don't have a smartknob I can't test it out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants