-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animated dice rolls #511
Conversation
Visit the preview URL for this PR (updated for commit 860170f): https://iron-fellowship-dev--pr511-feat-animated-dice-xmxaypdy.web.app (expires Sun, 10 Nov 2024 04:40:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4789204539639faf2e056a0ca1afe6984016b5d7 |
Visit the preview URL for this PR (updated for commit 860170f): https://crew-link-dev--pr511-feat-animated-dice-h4w5ggzj.web.app (expires Sun, 10 Nov 2024 04:39:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: ac5b7c2b217e7297177075d0f9d5001772953ac5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
src/api-calls/user/_user.type.ts
Outdated
@@ -8,4 +8,5 @@ export interface UserDocument { | |||
layout?: { | |||
referenceSidebarLocation?: ReferenceSidebarLocation; | |||
}; | |||
hideDice?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - this could be a little more specific.
Perhaps show3dDice
if the feature is opt-in or hide3dDice
if opt out?
src/styles.css
Outdated
#dice-box canvas { | ||
position: fixed; | ||
pointer-events: none; | ||
z-index: 100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add configurable animated dice rolls using https://www.npmjs.com/package/@3d-dice/dice-box