Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animated dice rolls #511

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Add animated dice rolls #511

merged 5 commits into from
Nov 5, 2024

Conversation

AG-Guardian
Copy link
Collaborator

Add configurable animated dice rolls using https://www.npmjs.com/package/@3d-dice/dice-box

Copy link

github-actions bot commented Nov 2, 2024

Visit the preview URL for this PR (updated for commit 860170f):

https://iron-fellowship-dev--pr511-feat-animated-dice-xmxaypdy.web.app

(expires Sun, 10 Nov 2024 04:40:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4789204539639faf2e056a0ca1afe6984016b5d7

Copy link

github-actions bot commented Nov 2, 2024

Visit the preview URL for this PR (updated for commit 860170f):

https://crew-link-dev--pr511-feat-animated-dice-h4w5ggzj.web.app

(expires Sun, 10 Nov 2024 04:39:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ac5b7c2b217e7297177075d0f9d5001772953ac5

scottbenton
scottbenton previously approved these changes Nov 3, 2024
Copy link
Owner

@scottbenton scottbenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@@ -8,4 +8,5 @@ export interface UserDocument {
layout?: {
referenceSidebarLocation?: ReferenceSidebarLocation;
};
hideDice?: boolean;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit - this could be a little more specific.

Perhaps show3dDice if the feature is opt-in or hide3dDice if opt out?

src/styles.css Outdated
#dice-box canvas {
position: fixed;
pointer-events: none;
z-index: 100;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor issue on mobile: the dice sometimes land underneath the floating top bar. I think I'd rather have them appear overt top, so some z-index changes might need to be made.
image

@scottbenton scottbenton merged commit 99a60a6 into beta Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants