Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX:872] Corrected websocket server url #875

Closed
wants to merge 1 commit into from
Closed

[FIX:872] Corrected websocket server url #875

wants to merge 1 commit into from

Conversation

hv7214
Copy link

@hv7214 hv7214 commented Jan 31, 2020

Description

Earlier, websockets were unable to connect to aria2c server. Problem behind this was aria_server key value in dl.conf. So replaced old value by ws://localhost:6800/jsonrpc.
If aria2c is used for deployment, then we should make different keys for development and deployment.

Related Issue

#872 .

Motivation and Context

In development environment our hostname is localhost.

How Has This Been Tested?

Now no error named as Name or service is getting produced, in fact now websocket gets successfully connected to aria2c server. But there are some new errors being produced which i guess related to #806.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Do run sudo python3 setup develop to refresh ~/.config/bassa/dl.conf.

@hv7214 hv7214 requested review from kmehant and JaDogg January 31, 2020 07:17
@carpecodeum
Copy link

@hv7214 can you please show the errors being produced?

Copy link

@carpecodeum carpecodeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead on hard-coding it better make it a variable in a .env file in which the user is able to specify whether they are in development or production mode.

@kmehant
Copy link
Collaborator

kmehant commented Jan 31, 2020

I guess this is something already discussed in the docs and wiki of changing the host name. Please let me know if that thing is not mentioned anywhere and reopen this issue :)

@kmehant kmehant closed this Jan 31, 2020
@hv7214
Copy link
Author

hv7214 commented Feb 2, 2020

@kmehant i didn't find any such instruction in wiki/linux. Can you point it out ?

@kmehant
Copy link
Collaborator

kmehant commented Feb 2, 2020

Seems like that point has been missed while shifting docs to wiki.
Anyways please add that point here
#375
Which helps other new users while troubleshooting.
And also you can add this point that
For source code setup
Hostname = localhost
For container setup
Hostname = service name ( aria2c )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants