Add @SpringConversion converter
#4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scordio
force-pushed
the
spring-conversion
branch
2 times, most recently
from
c3a4c44 to
c8268bf
Compare
6 tasks
scordio
force-pushed
the
spring-conversion
branch
3 times, most recently
from
abe254a to
480bb56
Compare
scordio
force-pushed
the
main
branch
2 times, most recently
from
3ee89d8 to
7eb3857
Compare
Owner
Author
|
@copilot rebase this PR and update the user guide with this new feature |
scordio
force-pushed
the
spring-conversion
branch
9 times, most recently
from
99aa185 to
db785c4
Compare
scordio
force-pushed
the
spring-conversion
branch
from
db785c4 to
7dd9d84
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Spring Framework type conversion to JUnit parameterized tests through a new @SpringConversion annotation.
- Introduces a new
@SpringConversionannotation that delegates to Spring'sDefaultConversionService - Adds comprehensive test coverage and documentation for various conversion scenarios
- Configures the dependency as optional to avoid forcing Spring on all users
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/io/github/scordio/junit/converters/SpringConversion.java | New annotation for Spring-based argument conversion |
| src/main/java/io/github/scordio/junit/converters/SpringArgumentConverter.java | Converter implementation delegating to Spring's ConversionService |
| src/main/java/module-info.java | Adds static optional dependency on spring.core module |
| src/test/java/module-info.java | Adds test module dependency on spring.core |
| src/test/java/io/github/scordio/tests/junit/converters/SpringConversionIntegrationTests.java | Integration tests for supported conversion scenarios |
| src/demo/java/io/github/scordio/SpringConversionDemo.java | Demo code showing annotation usage |
| pom.xml | Adds optional spring-core dependency and enforcer plugin configuration |
| docs/converters/spring-conversion.md | Documentation with usage examples and conversion tables |
| docs/index.md | Updates converter list to include SpringConversion |
| mkdocs.yml | Adds navigation entry and enables TOC integration |
| docs/converters/base64.md | Removes TOC hiding configuration |
| docs/converters/hex.md | Removes TOC hiding configuration |
| .github/workflows/main.yml | Adds CI job to test against Spring Framework 6.2.12 and 7.0.0-RC3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/io/github/scordio/junit/converters/SpringArgumentConverter.java
Outdated
Show resolved
Hide resolved
scordio
force-pushed
the
spring-conversion
branch
from
7dd9d84 to
f799233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.