Add option for multiple promises #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.all and it's type structure
|
@scopsy will you be able to take a look? |
ericberens
reviewed
Mar 26, 2020
| * @param { Promise } promise | ||
| * @param { Object= } errorExt - Additional Information you can pass to the err object | ||
| * @return { Promise } | ||
| * Resolves a promise to an array containting error (or undefined if promise succeeds), |
There was a problem hiding this comment.
Suggested change
| * Resolves a promise to an array containting error (or undefined if promise succeeds), | |
| * Resolves a promise to an array containing error (or undefined if promise succeeds), |
scopsy
reviewed
Jan 10, 2021
Comment on lines
+167
to
+182
| export function toAll<T1, T2, T3, U = Error>( | ||
| values: [T1 | PromiseLike<T1>, T2 | PromiseLike<T2>, T3 | PromiseLike<T3>], | ||
| errorExt?: object | ||
| ): Promise<[U | null, [T1, T2, T3] | undefined]>; | ||
|
|
||
| /** | ||
| * Uses Promise.all to resolve with an array containting error (or undefined if all of the promises succeed), | ||
| * and an array of results (or null if any of the promises fail) | ||
| * @param values An array of Promises. | ||
| * @param errorExt Additional Information you can pass to the err object | ||
| * @returns A new Promise. | ||
| */ | ||
| export function toAll<T1, T2, U = Error>( | ||
| values: [T1 | PromiseLike<T1>, T2 | PromiseLike<T2>], | ||
| errorExt?: object | ||
| ): Promise<[U | null, [T1, T2] | undefined]>; |
There was a problem hiding this comment.
Maybe there is a better way to represent this in TS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also in this PR: