Fix remaining memory leak

scopendo · Oct 22, 2020 · 28d105e · 28d105e
1 parent 7977129
commit 28d105e
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 1 deletion.
diff --git a/packages/flutter_riverpod/CHANGELOG.md b/packages/flutter_riverpod/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.12.1
+
+- Fixed an remaining memory leak related to StreamProvider (see also https://github.com/rrousselGit/river_pod/issues/193)
+
 # 0.12.0
 
 - **Breaking** FutureProvider and StreamProvider no-longer supports `null` as a valid value.

diff --git a/packages/hooks_riverpod/CHANGELOG.md b/packages/hooks_riverpod/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.12.1
+
+- Fixed an remaining memory leak related to StreamProvider (see also https://github.com/rrousselGit/river_pod/issues/193)
+
 # 0.12.0
 
 - **Breaking** FutureProvider and StreamProvider no-longer supports `null` as a valid value.

diff --git a/packages/riverpod/CHANGELOG.md b/packages/riverpod/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 0.12.1
+
+- Fixed an remaining memory leak related to StreamProvider (see also https://github.com/rrousselGit/river_pod/issues/193)
+
 # 0.12.0
 
 - **Breaking** FutureProvider and StreamProvider no-longer supports `null` as a valid value.

diff --git a/packages/riverpod/lib/src/stream_provider/auto_dispose.dart b/packages/riverpod/lib/src/stream_provider/auto_dispose.dart
@@ -9,7 +9,7 @@ class AutoDisposeStreamProvider<T>
   AutoDisposeStreamProvider(
     Create<Stream<T>, AutoDisposeProviderReference> create, {
     String name,
-  }) : super((ref) => create(ref).asBroadcastStream(), name);
+  }) : super(create, name);
 
   /// {@macro riverpod.family}
   static const family = AutoDisposeStreamProviderFamilyBuilder();

diff --git a/packages/riverpod/test/framework2/stream_provider_test.dart b/packages/riverpod/test/framework2/stream_provider_test.dart
@@ -73,6 +73,32 @@ void main() {
     expect(didCloseSub, true);
   });
 
+  test('the created stream does not leak on autoDispose providers', () async {
+    final container = ProviderContainer();
+    var didCloseSub = false;
+    final controller = StreamController<int>(
+      onCancel: () => didCloseSub = true,
+    );
+    addTearDown(controller.close);
+
+    final provider = StreamProvider.autoDispose((ref) => controller.stream);
+
+    var didCloseProxy = false;
+
+    final sub = container.listen(provider.stream);
+    sub.read().listen((_) {}, onDone: () => didCloseProxy = true);
+
+    await Future(() {});
+    expect(didCloseProxy, false);
+    expect(didCloseSub, false);
+
+    container.dispose();
+    await Future(() {});
+
+    expect(didCloseProxy, true);
+    expect(didCloseSub, true);
+  });
+
   test('the created stream does not leak on refresh', () async {
     final container = ProviderContainer();
     var didCloseSub = false;