WIP: Add elbv2 #164
Draft
WIP: Add elbv2 #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im trying to support both loadbalancer versions.
Both have
elasticloadbalancingin their ARN.How shall we handle this case ?
Should we just manipulate the output ARN of elbv1 resources and leave the "entry" pattern at "elb" ?
I think there is currently no way to support mapping elasticloadbalancing to two different classes
skew/resources/__init__.pyFuthermore I'm struggling a bit to get the elbv2 test working, am I doing something wrong in the placebo setup?
Thanks!