refactor: more API naming work #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
reviewed
May 26, 2023
There was a problem hiding this comment.
I suppose these functions are renamed to _comp_compgen_NAME like _comp_compgen_filedir as discussed in
- Use _comp_split and _comp_compgen in completions/* #948 (comment)
- Customizability and naming conventions for each completion #539 (comment) (the third item in the list)
Also, small implementation adjustments might be needed so that they can be called with _comp_compgen [options] NAME .... I submitted PR #993 (which I was originally planning to submit later) because it contains some hints on _comp_compgen_NAME.
Per current naming convention.
Removal of these is a breaking change, but the replacements are not public, and we don't want possible users to move to using the private ones.
Per current naming convention.
Per current naming convention.
Per current naming convention.
Per current naming convention.
scop
force-pushed
the
refactor/api-and-naming
branch
from
aa4d4bb to
cac2724
Compare
akinomyoga
force-pushed
the
refactor/api-and-naming
branch
from
12c2eee to
213dabe
Compare
akinomyoga
force-pushed
the
refactor/api-and-naming
branch
from
213dabe to
f475b2e
Compare
scop
commented
Jun 1, 2023
|
Thanks! |
akinomyoga
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.