feat: no empty command completion if no_empty_cmd_completion is on
#978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
May 12, 2023
scop
commented
May 12, 2023
scop
force-pushed
the
feat/no-empty-cmd
branch
3 times, most recently
from
95db0b3 to
2a20305
Compare
akinomyoga
reviewed
May 26, 2023
There was a problem hiding this comment.
There are some other cases where we might suppress command name generations on empty completions.
./bash_completion:2497: _comp_compgen -- -d -c
./completions/_su:23: _comp_compgen -- -d -c
./completions/gdb:23: _comp_compgen -- -d -cCurrently, _comp_compgen_commands only generates the command names, but maybe it could also generate directories by plusdirs by default.
|
Good points. Added The note in gdb completion regarding bash builtins etc being include is valid for quite a few other things as well, that's something we may want to address sometime. |
akinomyoga
reviewed
May 28, 2023
akinomyoga
reviewed
May 28, 2023
On some systems, generating the entire list of available commands takes a long time. `no_empty_cmd_completion` is semantically close enough to piggyback on it here. Closes #926
It makes sense to offer completions from explicitly specified paths, too. Thanks-to: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
akinomyoga
approved these changes
Jun 1, 2023
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, generating the entire list of available commands takes a long time.
no_empty_cmd_completionis semantically close enough to piggyback on it here.Closes #926