fix(bash_completion): use _comp_split and new _comp_compgen for safer splitting
#919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
_comp_split
branch
2 times, most recently
from
fa65c68 to
af57fd5
Compare
scop
reviewed
Apr 10, 2023
akinomyoga
force-pushed
the
_comp_split
branch
2 times, most recently
from
7f2168f to
9c92730
Compare
scop
approved these changes
Apr 15, 2023
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
akinomyoga
force-pushed
the
_comp_split
branch
2 times, most recently
from
cdeda74 to
eaeb53e
Compare
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
We allow positional parameters ($1...) in the current word specified as `-- CUR` at the end of the argument list.
We needed to adjust IFS for splitting before, but we do not need it now because we switched to `_comp_split`. IFS is anyway adjusted by callers `_parse_help` and `_part_usage`. Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
|
Added https://github.com/scop/bash-completion/projects/2#card-89052206 for the completions/* work, perhaps that's something we could try to do for 2.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have a utility function
_comp_splitto safely split strings (including the output of thecompgenbuiltin and other commands) without being affected by pathname expansions, unexpected word splitting, etc. I would like to switch from the repeatedlocal IFS=... reset=$(shopt -po noglob); set -o noglob; ...; IFS=$' \t\n'; $resetto_comp_split._comp_splitto return whether nonzero elements are produced in the exit status. This is because((${#arr[@]}))is tested in many cases after splitting strings._comp_split -l arr "$(compgen ARGS)", so it is useful to define a function_comp_compgen arr ARGS(in particular to reduce nested quoting and command substitutions)._comp_compgen, etc.The changes suggested in this PR are actually the ones that I mentioned in the following PRs before.
compgen -W '${arr[@]}'#887 (comment)The changes to
completions/*are left for later PRs.