feat(__load_completion): load in-tree before system data dirs #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This swaps the lookup order of in-tree (relative to the main script) and system data dirs. By checking in-tree completions first, before system data dirs, we support setups running directly from a git clone better, and have a more robust setup in any case. The main script and in-tree completions should stay in sync. There might for example be internal API changes between releases which wouldn't work if the main `bash_completion` and the set of completions we ship were from different versions, e.g. from git and a release. Refs #537 (reply in thread)
|
I think a part of this change overlaps with #696. |
|
Oh, indeed, I had forgotten about that one. Sorry, and thanks for picking up these changes there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps the lookup order of in-tree (relative to the main script) and system data dirs. By checking in-tree completions first, before system data dirs, we support setups running directly from a git clone better, and have a more robust setup in any case.
The main script and in-tree completions should stay in sync. There might for example be internal API changes between releases which wouldn't work if the main
bash_completionand the set of completions we ship were from different versions, e.g. from git and a release.Refs #537 (reply in thread)