Skip to content

test(Makefile.am): update EXTRA_DIST in Makefile.am #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

akinomyoga
Copy link
Collaborator

I noticed that the tests in #793 and #791 are actually not run in CI. I found that also other files are not included in Makefile.am.

@akinomyoga
Copy link
Collaborator Author

I have fixed an issue of the test code found by CI #602. The tempenv for the shell functions (i.e., tempenv=value func) persists after the function call in the POSIX mode in Bash 4.2..5.0. Instead of using temporary environments, I changed to use local variables.

@scop
Copy link
Owner

scop commented Sep 2, 2022

Nice catch, thanks!

@scop scop merged commit f736bb0 into scop:master Sep 2, 2022
@akinomyoga akinomyoga deleted the EXTRA_DIST branch September 2, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants