style: prefer empty/! over -n/-z
#740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until we have the actual sweeping code changes here as well. |
|
Rebased and hopefully completed. This might interfere/conflict with other sweeping changes going on -- if so, we can leave this for later and process more important things first, or sneak this in in the middle, I don't mind :) |
akinomyoga
approved these changes
Apr 13, 2022
|
Thanks! I'm fine with merging this PR. You can merge it any time now or later when you think it is useful. |
akinomyoga
requested changes
Apr 13, 2022
Per the style guide.
Per the style guide.
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally from comments in #678.
Docs only for now; we should implement the actual change in this PR too.