Open
Conversation
Reproducible e.g. by starting our test centos7 container in interactive mode, and then immediately `pytest test/t/test_kill.py` in it.
scop
commented
Mar 1, 2026
Comment on lines
+8
to
+9
| completion # more than one starting with 1 | ||
| or completion.endswith(" ") # pid 1 only |
Owner
Author
There was a problem hiding this comment.
This has a code smell to me -- would have expected completion to be ["1"] offhand when the only completion is 1 and thus completion to be truthy. But I've forgotten about the dirty details, maybe this is how it should be done.
Collaborator
There was a problem hiding this comment.
I think completion contains the added suffix for a unique completion. In this case, completion == " " should be more specific.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducible e.g. by starting our test centos7 container in interactive mode, and then immediately
pytest test/t/test_kill.pyin it.