Skip to content

curl, wget: Complete IP addresses, including ipv6 for --interface and --bind-address #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2025
Merged

curl, wget: Complete IP addresses, including ipv6 for --interface and --bind-address #1316

merged 2 commits into from
Jan 20, 2025

Conversation

yedayak
Copy link
Collaborator

@yedayak yedayak commented Jan 15, 2025 •
edited
Loading

Closes #1315

@yedayak yedayak force-pushed the curl-interface-ips branch from 07d6454 to a23b986 Compare January 15, 2025 21:32
@yedayak yedayak changed the title feat(curl): Complete IP addresses for --interface curl, wget Complete IP addresses, including ipv6 for --interface and --bind-address Jan 15, 2025
@yedayak yedayak mentioned this pull request Jan 15, 2025
Closed
2 tasks
@yedayak yedayak changed the title curl, wget Complete IP addresses, including ipv6 for --interface and --bind-address curl, wget: Complete IP addresses, including ipv6 for --interface and --bind-address Jan 15, 2025
@SoniEx2
Copy link

SoniEx2 commented Jan 15, 2025

looks good! tho there is an issue with the wget completion where we can start the completion but not finish it. the curl works perfectly tho! thanks ^^

@SoniEx2
Copy link

SoniEx2 commented Jan 15, 2025

(ah we see, it seems that is answered in the README. unsure why it works for curl tho.)

@yedayak yedayak force-pushed the curl-interface-ips branch from a23b986 to ee35daf Compare January 19, 2025 19:24
@yedayak
Copy link
Collaborator Author

yedayak commented Jan 19, 2025 •
edited
Loading

(ah we see, it seems that is answered in the README. unsure why it works for curl tho.)

Yeah I missed this about _comp_compgen_ip_addresses:

# If producing IPv6 completions, `_comp_initialize` with `-n :`.

Fixed, and added tests

@yedayak yedayak force-pushed the curl-interface-ips branch from ee35daf to d227c1f Compare January 19, 2025 19:54
@yedayak
Copy link
Collaborator Author

yedayak commented Jan 20, 2025

@SoniEx2 Does this fix the issue?

@SoniEx2
Copy link

SoniEx2 commented Jan 20, 2025

yes! thanks!

@yedayak yedayak merged commit d3ff6a7 into scop:main Jan 20, 2025
7 checks passed
@yedayak yedayak deleted the curl-interface-ips branch January 20, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akinomyoga akinomyoga akinomyoga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IPv6 when completing wget/curl
3 participants
@yedayak @SoniEx2 @akinomyoga