fix: fix misc problems before applying _comp_split changes
#1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since IFS is specified, I guess this intends to split the content of $fmri by /. However, the word splitting does not happen because the entire word is quoted as `"$fmri"`. This quoting was introduced in commit 9ba5831 [1] to suppress shellcheck SC2086. In this patch, we split $fmri by `_comp_split`. [1] \ scop@9ba5831#diff-4e8aeaa79512c947f5558a112a1b5946b36604cef5229f622c05852d807c7947R48
akinomyoga
force-pushed
the
_comp_split-0
branch
from
5665d1e to
b6b2f12
Compare
This was referenced Jan 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a set of trivial fixes that I would like to apply before submitting the _comp_split/_comp_compgen_split/_comp_expand_glob changes.