Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new GenAI metadata definition #930

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Add GenAI* Metadata support starting v60

Does this close any currently open issues?


closes #929

@scolladon
Copy link
Owner Author

Hi @gavignon !

Could you test on your side and help us validate this PR please ?
You can follow those steps to easily do it

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f190319) to head (16ef09f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #930   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1083      1083           
  Branches       115       115           
=========================================
  Hits          1083      1083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Oct 7, 2024

Code Climate has analyzed commit 16ef09f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@mehdicherf mehdicherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scolladon
Copy link
Owner Author

GenAIFunction tested more robustly because it is a bundle type

  • Addition ✅
  • modification of schema ✅
  • modification of meta file ✅
  • deletion ✅

@scolladon scolladon merged commit 8e0e4bd into main Oct 8, 2024
19 of 22 checks passed
@scolladon scolladon deleted the feat/add-genAI-metadata-support branch October 8, 2024 10:32
Copy link

github-actions bot commented Oct 8, 2024

Shipped in release v5.47.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.47.0

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing genAI Metadata Types
2 participants