-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add FeatureParameter metadata support #915
feat: add FeatureParameter metadata support #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, thanks !!!
Could the definition be at the top of the file ?
Also, has it been tested manually ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 1083 1083
Branches 115 115
=========================================
Hits 1083 1083 ☔ View full report in Codecov by Sentry. |
ed6f70f
to
ead7929
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting the definition on top of the file.
The bottom is reserved to certain types I prefer to be grouped.
Could you add an integration test for those types please ?
You just have to add an item in the list for each new type.
If you struggle with that I can add it, just let me know
As they are regrouped in the same folder I would like to couple the test with the metadata definition, just to fix the spec explicitely
ead7929
to
7675772
Compare
Code Climate has analyzed commit 7675772 and detected 0 issues on this pull request. View more on Code Climate. |
I added the integration tests, though I'm not familiar with that so I just followed the other patterns. Let me know if it needs additional fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great job, thanks for this contribution
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.44.0 Happy incremental deployment! |
Explain your changes
Add metadata support for all three types of Feature Parameters: