Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ConversationMessageDefinition metadata support #899

Merged
merged 2 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions __tests__/__utils__/globalTestHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import {
} from '../../src/metadata/metadataManager'
import type { Work } from '../../src/types/work'

require('ts-node/register')

export const getGlobalMetadata = async (): Promise<MetadataRepository> => {
const apiVersion: number = await getLatestSupportedVersion()
const metadata: MetadataRepository = await getDefinition(apiVersion)
Expand Down
12 changes: 6 additions & 6 deletions __tests__/functional/main.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
;`use strict`
'use strict'
import { expect, jest, describe, it } from '@jest/globals'

// eslint-disable-next-line @typescript-eslint/no-var-requires
const sgd = require('../../src/main')
import sgd from '../../src/main'
import type { Config } from '../../src/types/config'

const mockValidateConfig = jest.fn()
jest.mock('../../src/utils/cliHelper', () => {
Expand Down Expand Up @@ -57,7 +57,7 @@ describe('external library inclusion', () => {

// Act
try {
await sgd({})
await sgd({} as Config)
} catch (error) {
// Assert
expect((error as Error).message).toEqual('test')
Expand All @@ -72,7 +72,7 @@ describe('external library inclusion', () => {
})
it('it should not process lines', async () => {
// Act
await sgd({})
await sgd({} as Config)

// Assert
expect(mockProcess).toBeCalledWith([])
Expand All @@ -86,7 +86,7 @@ describe('external library inclusion', () => {
})
it('it should process those lines', async () => {
// Act
await sgd({})
await sgd({} as Config)

// Assert
expect(mockProcess).toBeCalledWith(['line'])
Expand Down
22 changes: 11 additions & 11 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"author": "Sebastien Colladon <colladonsebastien@gmail.com>",
"dependencies": {
"@salesforce/command": "^5.3.9",
"@salesforce/core": "^8.2.7",
"@salesforce/core": "^8.2.8",
"async": "^3.2.5",
"fast-xml-parser": "^4.4.1",
"fs-extra": "^11.2.0",
Expand Down Expand Up @@ -224,18 +224,18 @@
"@jest/globals": "^29.7.0",
"@ls-lint/ls-lint": "^2.2.3",
"@oclif/dev-cli": "^1.26.10",
"@salesforce/cli-plugins-testkit": "^5.3.20",
"@salesforce/cli-plugins-testkit": "^5.3.23",
"@salesforce/dev-config": "^4.1.0",
"@salesforce/ts-sinon": "^1.4.23",
"@stryker-mutator/core": "^8.2.6",
"@stryker-mutator/jest-runner": "^8.2.6",
"@swc/core": "^1.7.3",
"@salesforce/ts-sinon": "^1.4.24",
"@stryker-mutator/core": "^8.3.0",
"@stryker-mutator/jest-runner": "^8.3.0",
"@swc/core": "^1.7.6",
"@types/async": "^3.2.24",
"@types/jest": "^29.5.12",
"@types/mocha": "^10.0.7",
"@types/node": "^22.0.0",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"@types/node": "^22.1.0",
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"benchmark": "^2.1.4",
"chai": "^4.3.10",
"eslint": "^8.57.0",
Expand All @@ -245,13 +245,13 @@
"husky": "^9.1.4",
"jest": "^29.7.0",
"knip": "^5.27.0",
"lint-staged": "^15.2.7",
"lint-staged": "^15.2.8",
"mocha": "^10.7.0",
"nyc": "^17.0.0",
"prettier": "^3.3.3",
"shx": "^0.3.4",
"sinon": "^18.0.0",
"ts-jest": "^29.2.3",
"ts-jest": "^29.2.4",
"ts-node": "^10.9.2",
"tslib": "^2.6.3",
"typescript": "^5.5.4",
Expand Down
7 changes: 7 additions & 0 deletions src/metadata/v59.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
[
{
"directoryName": "conversationMessageDefinitions",
"inFolder": false,
"metaFile": false,
"suffix": "conversationMessageDefinition",
"xmlName": "ConversationMessageDefinition"
},
{
"directoryName": "dw",
"inFolder": false,
Expand Down
7 changes: 7 additions & 0 deletions src/metadata/v60.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
[
{
"directoryName": "conversationMessageDefinitions",
"inFolder": false,
"metaFile": false,
"suffix": "conversationMessageDefinition",
"xmlName": "ConversationMessageDefinition"
},
{
"directoryName": "genAiPromptTemplateActivations",
"inFolder": false,
Expand Down
7 changes: 7 additions & 0 deletions src/metadata/v61.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
[
{
"directoryName": "conversationMessageDefinitions",
"inFolder": false,
"metaFile": false,
"suffix": "conversationMessageDefinition",
"xmlName": "ConversationMessageDefinition"
},
{
"directoryName": "genAiPromptTemplateActivations",
"inFolder": false,
Expand Down
2 changes: 1 addition & 1 deletion src/utils/cliHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class CLIHelper {
try {
const ref: string = await this.gitAdapter.parseRev(shaValue)
;(this.config[shaParameter] as string) = ref
} catch (error) {
} catch {
errors.push(
format(messages.errorParameterIsNotGitSHA, shaParameter, shaValue)
)
Expand Down
2 changes: 1 addition & 1 deletion src/utils/fsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export const readPathFromGit = async (forRef: FileGitRef, config: Config) => {
try {
const gitAdapter = GitAdapter.getInstance(config)
utf8Data = await gitAdapter.getStringContent(forRef)
} catch (error) {
} catch {
/* empty */
}
return utf8Data
Expand Down
Loading
Loading